Migrate Makefile to portfolio conventions; bump to 0.0.4 #14

Merged
parkerhdavis merged 1 commit from makefile-convention-migration into main 2026-04-29 01:39:03 -06:00
parkerhdavis commented 2026-04-29 01:38:57 -06:00 (Migrated from github.com)

Summary

Bring Seria's Makefile in line with the portfolio Makefile conventions (12.03 Makefile Conventions.md in the vault). Folds in the staged 0.0.3 → 0.0.4 version bump.

Hot conflict (substantive):

  • The dev recipe used to launch the frontend itself (setsid bun run dev.ts + .dev.pid) — which duplicated what Tauri does via beforeDevCommand. tauri.conf.json now has beforeDevCommand set (object form with cwd: "../frontend"), so the recipe shrinks to a port pre-flight on :5173 then bunx tauri dev. down correspondingly drops .dev.pid handling and just kills on :5173.

Stylistic catch-up (Makefile reads like Lily/Packi/Poppy):

  • # ─── Seria Makefile ─── header banner.
  • # ─── Section ─── dividers in place of # === SECTION ===.
  • BACKEND / FRONTEND path variables; literal occurrences replaced.
  • help migrated from the verbose @echo block to the canonical ## comment + grep form. Because SHELL := pwsh.exe on Windows breaks the grep | sort | awk pipe, help is OS-conditional with a Select-String equivalent on the Windows branch.

Versioning:

  • 0.0.3 → 0.0.4 across package.json (root + apps/desktop/), tauri.conf.json, Cargo.toml, and Cargo.lock.

Test plan

  • make help lists every public target with its docstring (alphabetical sort, color-aligned).
  • make (bare) runs help via .DEFAULT_GOAL.
  • make typecheck passes.
  • make dev boots Tauri → Tauri spawns the frontend via beforeDevCommand → Cargo compiles → window comes up at :5173.
  • make down kills anything on :5173 and reports cleanly when nothing is running.
  • Windows path (SHELL := pwsh.exe) — not tested locally; recipe shape mirrors Lily/Packi.
## Summary Bring Seria's Makefile in line with the portfolio Makefile conventions (`12.03 Makefile Conventions.md` in the vault). Folds in the staged 0.0.3 → 0.0.4 version bump. **Hot conflict (substantive):** - The dev recipe used to launch the frontend itself (`setsid bun run dev.ts` + `.dev.pid`) — which duplicated what Tauri does via `beforeDevCommand`. `tauri.conf.json` now has `beforeDevCommand` set (object form with `cwd: "../frontend"`), so the recipe shrinks to a port pre-flight on `:5173` then `bunx tauri dev`. `down` correspondingly drops `.dev.pid` handling and just kills on `:5173`. **Stylistic catch-up (Makefile reads like Lily/Packi/Poppy):** - `# ─── Seria Makefile ───` header banner. - `# ─── Section ───` dividers in place of `# === SECTION ===`. - `BACKEND` / `FRONTEND` path variables; literal occurrences replaced. - `help` migrated from the verbose `@echo` block to the canonical `## comment` + grep form. Because `SHELL := pwsh.exe` on Windows breaks the `grep | sort | awk` pipe, `help` is OS-conditional with a `Select-String` equivalent on the Windows branch. **Versioning:** - 0.0.3 → 0.0.4 across `package.json` (root + `apps/desktop/`), `tauri.conf.json`, `Cargo.toml`, and `Cargo.lock`. ## Test plan - [x] `make help` lists every public target with its docstring (alphabetical sort, color-aligned). - [x] `make` (bare) runs `help` via `.DEFAULT_GOAL`. - [x] `make typecheck` passes. - [x] `make dev` boots Tauri → Tauri spawns the frontend via `beforeDevCommand` → Cargo compiles → window comes up at `:5173`. - [x] `make down` kills anything on `:5173` and reports cleanly when nothing is running. - [ ] Windows path (`SHELL := pwsh.exe`) — not tested locally; recipe shape mirrors Lily/Packi.
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
parker/seria!14
No description provided.